Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: machineset annotator #287

Closed

Conversation

michaelgugino
Copy link

Half-working pricing annotation controller.

We should use code-generation to incorporate the pricing similar to what the autoscaler does upstream, rather than attempt to use the pricing api (which is very problematic due to permissions, and region restrictions/networking).

Upstream cluster autoscaler downloads the pricing info for each provider, generates code with the pricing information, and that pricing information is built into the autoscaler binary. We could utilize the same here (ideally, make that logic more portable in the upstream autoscaler as well so we can just import the functionality).

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2020
@openshift-ci-robot
Copy link

@michaelgugino: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 23, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign michaelgugino
You can assign the PR to them by writing /assign @michaelgugino in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@michaelgugino: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/govet 90fa21f link /test govet
ci/prow/images 90fa21f link /test images
ci/prow/e2e-aws 90fa21f link /test e2e-aws
ci/prow/e2e-aws-upgrade 90fa21f link /test e2e-aws-upgrade
ci/prow/golint 90fa21f link /test golint
ci/prow/goimports 90fa21f link /test goimports
ci/prow/unit 90fa21f link /test unit
ci/prow/e2e-aws-operator 90fa21f link /test e2e-aws-operator
ci/prow/yaml-lint 90fa21f link /test yaml-lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants