New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1733474: Revendor MAO with new node draining feature check existence before node deletion #296
Bug 1733474: Revendor MAO with new node draining feature check existence before node deletion #296
Conversation
@alexander-demichev: This pull request references Bugzilla bug 1733474, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@alexander-demichev: This pull request references Bugzilla bug 1733474, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alexander-demichev can you please make sure this is backported to 4.3? |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
Revendor MAO with a new node draining feature and check for instance existence before proceeding with deletion.
openshift/machine-api-operator#464
openshift/machine-api-operator#490