Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1733474: Revendor MAO with new node draining feature check existence before node deletion #296

Merged
merged 1 commit into from Feb 17, 2020

Conversation

alexander-demicev
Copy link

@alexander-demicev alexander-demicev commented Feb 7, 2020

Revendor MAO with a new node draining feature and check for instance existence before proceeding with deletion.
openshift/machine-api-operator#464
openshift/machine-api-operator#490

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 7, 2020
@alexander-demicev alexander-demicev changed the title Revendor MAO with new node draining feature Bug 1733474: Revendor MAO with new node draining feature Feb 7, 2020
@openshift-ci-robot
Copy link

@alexander-demichev: This pull request references Bugzilla bug 1733474, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1733474: Revendor MAO with new node draining feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 7, 2020
@alexander-demicev
Copy link
Author

/retest

Copy link

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2020
@openshift-ci-robot
Copy link

@alexander-demichev: This pull request references Bugzilla bug 1733474, which is valid.

In response to this:

Bug 1733474: Revendor MAO with new node draining feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enxebre
Copy link
Member

enxebre commented Feb 17, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2020
@enxebre
Copy link
Member

enxebre commented Feb 17, 2020

@alexander-demichev can you please make sure this is backported to 4.3?

@enxebre enxebre changed the title Bug 1733474: Revendor MAO with new node draining feature Bug 1733474: Revendor MAO with new node draining feature check existence before node deletion Feb 17, 2020
@enxebre
Copy link
Member

enxebre commented Feb 17, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants