BUG 1831717: Ensure PublicIP is left out of JSON encoding if empty

[JoelSpeed]

Otherwise the value is rendered as null which is not a valid value for
a boolean and causes marshalling errors

Invalid value: "The edited file failed validation": unknown object type "nil" in MachineSet.spec.template.spec.providerSpec.value.publicIp

Came across this while trying to kubectl edit a MachineSet

This will need the installer to bump their dependency to fix this bug

[enxebre]

/approve
we need a bz

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@JoelSpeed: This pull request references Bugzilla bug 1831717, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

BUG 1831717: Ensure PublicIP is left out of JSON encoding if empty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

I've manually verified that this, in conjunction with the installer PR, solves the issue

[enxebre]

/lgtm

[openshift-ci-robot]

@JoelSpeed: Some pull requests linked via external trackers have merged: openshift/cluster-api-provider-aws#320. The following pull requests linked via external trackers have not merged:

• openshift/installer#3550 is open
  Bugzilla bug 1831717 has been moved to the MODIFIED state.

In response to this:

BUG 1831717: Ensure PublicIP is left out of JSON encoding if empty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.