BUG 1858400: [Performance] Lease refresh period for machine-api-controllers is too high, causes heavy writes to etcd at idle

[Danil-Grigorev]

The machine-api-controller components are refreshing their lease more
than all other components combined. Bringing this to 90s each, will
decrease etcd writes at idle.

Relevant MAO PR - openshift/machine-api-operator#649

[openshift-ci-robot]

@Danil-Grigorev: This pull request references Bugzilla bug 1858400, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

BUG 1858400: [Performance] Lease refresh period for machine-api-controllers is too high, causes heavy writes to etcd at idle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

/lgtm
Would it make sense to have a default for this in the MAO repo that can be vendored here? 🤔

[openshift-ci-robot]

@Danil-Grigorev: This pull request references Bugzilla bug 1858400, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

BUG 1858400: [Performance] Lease refresh period for machine-api-controllers is too high, causes heavy writes to etcd at idle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Danil-Grigorev]

/retest

[Danil-Grigorev]

/lgtm
Would it make sense to have a default for this in the MAO repo that can be vendored here? thinking

It may help, but re-vendor is always less visible and harder to track when then default value that will be set anyway in CLI.

[Danil-Grigorev]

@JoelSpeed @enxebre NIT: fixed typo in the commit message. Please LGTM?..

[JoelSpeed]

/lgtm

[enxebre]

the units are not passing

[Danil-Grigorev]

the units are not passing

Seems like a race in unit tests, but I can't reproduce the issue locally. Give me a second to investigate.

[Danil-Grigorev]

/retest

[Danil-Grigorev]

@enxebre This should be the fix for the race in unit tests: #340

[JoelSpeed]

Seems like a race in unit tests, but I can't reproduce the issue locally. Give me a second to investigate.

I think this race may actually be fixed by #337 (I saw the error before and included a "fix"(?) for it in that PR)

[JoelSpeed]

Either way, the race is unrelated to the changes in this PR
/retest

[enxebre]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@Danil-Grigorev: Some pull requests linked via external trackers have merged: openshift/machine-api-operator#649, openshift/cluster-api-provider-ovirt#56, openshift/cluster-api-provider-openstack#109, openshift/cluster-api-provider-gcp#104, openshift/cluster-api-provider-baremetal#88. The following pull requests linked via external trackers have not merged:

• openshift/cluster-api-provider-azure#152 is open
  Bugzilla bug 1858400 has been moved to the MODIFIED state.

In response to this:

BUG 1858400: [Performance] Lease refresh period for machine-api-controllers is too high, causes heavy writes to etcd at idle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.