Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2121: Add openshift/e2e-tests for CAPI E2E testing #465

Merged

Conversation

damdo
Copy link
Member

@damdo damdo commented Jun 21, 2023

This PR adds a script under openshift/e2e-tests.sh which can be invoked manually or through the OpenShift CI steps (as we already do for unit tests) to launch CAPI E2E tests from within the provider repo.

This mimics the approach in the MAPI providers where we clone the repo where the e2e tests reside and launch those from within the provider repo PRs.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 21, 2023

@damdo: This pull request references OCPCLOUD-2121 which is a valid jira issue.

In response to this:

This PR adds a script under openshift/e2e-tests.sh which can be invoked manually or through the OpenShift CI steps (as we already do for unit tests) to launch CAPI E2E tests from within the provider repo.

This mimics the approach in the MAPI providers where we clone the repo where the e2e tests reside and launch those from within the provider repo PRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from elmiko and RadekManak June 21, 2023 12:41
@damdo
Copy link
Member Author

damdo commented Jun 21, 2023

/assign @JoelSpeed

@JoelSpeed
Copy link

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3df1443 and 2 for PR HEAD 865ca31 in total

@damdo
Copy link
Member Author

damdo commented Jun 22, 2023

This change only introduces a script which doesn't affect the payload.
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-hypershift

@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2023

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws-serial, ci/prow/e2e-hypershift

In response to this:

This change only introduces a script which doesn't affect the payload.
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2023

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 70413c4 into openshift:master Jun 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants