Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2216,OCPBUGS-17279: Merge https://github.com/kubernetes-sigs/cluster-api-provider-aws:v2.2.4 (56c9a39) into master #478

Merged
merged 38 commits into from Oct 16, 2023

Conversation

damdo
Copy link
Member

@damdo damdo commented Oct 5, 2023

No description provided.

k8s-ci-robot and others added 30 commits July 7, 2023 04:09
The root metadata.yaml was missing the 2.1 and 2.2 release series which
was causing an issue with the recent 2.2.0 release.

Signed-off-by: Richard Case <richard.case@suse.com>
…ot/cherry-pick-4386-to-release-2.2

[release-2.2] chore: update metedata.yaml with the release series
(cherry picked from commit 4ff5e37)
Signed-off-by: Tobias Giese <tobias.giese@mercedes-benz.com>
…ot/cherry-pick-4357-to-release-2.2

[release-2.2] Add elasticloadbalancing:SetSubnets to cloudformation
This implements a GHA workflow that will automatically approve actions
to run when there is an `ok-to-test`.

This has been copied from upstream CAPI.

Signed-off-by: Richard Case <richard.case@outlook.com>
…ot/cherry-pick-4467-to-release-2.2

[release-2.2] chore: approve actions on ok-to-test
This change moves us back to using the k/k releas-notes tool to generate
our changelog for a release.

Signed-off-by: Richard Case <richard.case@outlook.com>
…ot/cherry-pick-4472-to-release-2.2

[release-2.2] feat: use k/k tooling for release notes
…ot/cherry-pick-4406-to-release-2.2

[release-2.2] Allow securing api LB, only allowing traffic from required sources
…ot/cherry-pick-4495-to-release-2.2

[release-2.2] Fix error loop for ignition
This ensures that failure domains are correctly set when using an externally managed (BYO) NLB
…ot/cherry-pick-4449-to-release-2.2

[release-2.2] Set availability zones in status.networkStatus.apiServerElb when using BYO NLB
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
…ot/cherry-pick-4463-to-release-2.2

[release-2.2] fix: don't generate nodegroup role name starting with hyphen
…ot/cherry-pick-4508-to-release-2.2

[release-2.2] Save Nat Gateways IPs to status on every reconciliation
Fix setting additional ingress rules for CP

Update documentation with CP ingress rules
…08-to-release-2.2

[release-2.2] Add additional ingress rules for CP to API
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
The tests where failing after upgrading controller-runtime due to changes in
the fake client.

Signed-off-by: Richard Case <richard.case@outlook.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 5, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2023

@damdo: This pull request references OCPCLOUD-2216 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo
Copy link
Member Author

damdo commented Oct 5, 2023

/retest

@damdo
Copy link
Member Author

damdo commented Oct 9, 2023

/hold
For manual testing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2023

@damdo: This pull request references OCPCLOUD-2216 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo
Copy link
Member Author

damdo commented Oct 9, 2023

/retest

3 similar comments
@damdo
Copy link
Member Author

damdo commented Oct 9, 2023

/retest

@damdo
Copy link
Member Author

damdo commented Oct 9, 2023

/retest

@damdo
Copy link
Member Author

damdo commented Oct 9, 2023

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
@JoelSpeed JoelSpeed changed the title OCPCLOUD-2216: Merge https://github.com/kubernetes-sigs/cluster-api-provider-aws:v2.2.4 (56c9a39) into master OCPCLOUD-2216,OCPBUGS-17279: Merge https://github.com/kubernetes-sigs/cluster-api-provider-aws:v2.2.4 (56c9a39) into master Oct 12, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 12, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 12, 2023

@damdo: This pull request references OCPCLOUD-2216 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

This pull request references Jira Issue OCPBUGS-17279, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo
Copy link
Member Author

damdo commented Oct 16, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2023
@damdo
Copy link
Member Author

damdo commented Oct 16, 2023

/tide refresh

@openshift-ci openshift-ci bot merged commit 368de23 into openshift:master Oct 16, 2023
8 checks passed
@openshift-ci-robot
Copy link

@damdo: Jira Issue OCPBUGS-17279: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17279 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.15.0-0.nightly-2023-10-17-065657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet