Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-21649: Bump golang.org/x/net to v0.17.0 #479

Merged
merged 1 commit into from Oct 18, 2023

Conversation

damdo
Copy link
Member

@damdo damdo commented Oct 16, 2023

Bumps the golang.org/x/net dep to v0.17.0

@damdo damdo changed the title Bump golang.org/x/net to v0.17.0 OCPBUGS-21649: Bump golang.org/x/net to v0.17.0 Oct 16, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 16, 2023
@openshift-ci-robot
Copy link

@damdo: This pull request references Jira Issue OCPBUGS-21649, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bumps the golang.org/x/net dep to v0.17.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link

elmiko commented Oct 16, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@damdo
Copy link
Member Author

damdo commented Oct 17, 2023

Can I get an approval here @JoelSpeed ? Thx

@JoelSpeed
Copy link

Why a carry? Can we raise a PR upstream to resolve this and reference it downstream?

@damdo
Copy link
Member Author

damdo commented Oct 17, 2023

It is already fixed upstream but hasn't been released in 5+ days.
I think we can carry for now and drop in the next rebase.

@JoelSpeed
Copy link

In that case, you should use an UPSTREAM: <drop>: or UPSTREAM: ####: PR number style prefix for the commit, so that the rebase bot knows what to do when it comes to the rebase

@damdo damdo force-pushed the bump-golang.org-x-net-v0.17.0 branch from e9e7e0a to d7e65ba Compare October 17, 2023 20:32
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@damdo
Copy link
Member Author

damdo commented Oct 17, 2023

@JoelSpeed added the upstream PR reference in the commit.

@damdo
Copy link
Member Author

damdo commented Oct 18, 2023

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@openshift-ci openshift-ci bot merged commit 48fceb3 into openshift:master Oct 18, 2023
8 checks passed
@openshift-ci-robot
Copy link

@damdo: Jira Issue OCPBUGS-21649: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-21649 has been moved to the MODIFIED state.

In response to this:

Bumps the golang.org/x/net dep to v0.17.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.15.0-0.nightly-2023-10-24-230302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants