NO-JIRA: Merge https://github.com/kubernetes-sigs/cluster-api-provider-aws:v2.4.2 (1c23009) into master #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#4907) * 🐛 fix: s3: do not ignore non-aws errors when deleting object If any error of non awserr.Error type happens when trying to list a bootstrap data object, it would be silently ignored. * 🐛fix: s3: ignore "NotFound" errors The `s3.HeadObject` API call can return "NotFound" when either the bucket or the object does not exist (as opposed to the more descriptive `s3.ErrCodeNoSuchKey` or `s3.ErrCodeNoSuchBucket`). This would cause the machine controller to loop indefinitely trying to delete an already deleted object but failing: ``` E0316 16:37:08.973942 366 awsmachine_controller.go:307] "unable to delete machine" err=< deleting bootstrap data object: deleting S3 object: NotFound: Not Found status code: 404, request id: 5Z101DW1KN380WTY, host id: tYlSi9K38lBkIsr2DNf/xFfgDuFaVfeUmpscXdljiMZC5iRxPIDuXSLwHJwdFnosYCfi7Bih25GaDpVAbSq4ZA== > ``` * 🌱s3: add unit test for already deleted s3 object. --------- Co-authored-by: Rafael Fonseca <r4f4rfs@gmail.com>
…igs#4908) * 🐛ec2: instances: fix check for public subnets It's not enough to check MapPublicIPOnLaunch since public subnets can have that off. * 🐛ec2: instances: fix assigning public IP In the scenario where the user brings their own VPC, if no subnet ID is set in the machine spec and PublicIP is true, CAPA will choose one from the available public subnets. However, if the subnet doesn't have MapPublicIPOnLaunch == true, the instance will not be assigned a public IP. As a result, the instance will have no internet access, contrary to the user's expectation. This change guarantees an instance will be assigned a public IP even if the subnet doesn't do it on instance launch. Instead, we set the option in the instance's network interface. * 🌱ec2: instances: add unit tests for MapPublicIpOnLaunch=false The tests check that a NetworkInterface is defined with `AssociatePublicIpAddress` in the `RunInstances` input. --------- Co-authored-by: Rafael Fonseca <r4f4rfs@gmail.com>
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Route tables must be deleted after fail to create, otherwise it will generate a new route table every new reconciliator loop. This fix ensure route table is deleted when failed to create, raising a wanring to the recorder when failed to create, and eventually, failed to delete.
Ingress rules from both primary and secondary load balancers must be taken into account.
Signed-off-by: melserngawy <melserng@redhat.com>
…ot/cherry-pick-4896-to-release-2.4 [release-2.4] 🐛Retry fetching user data from secretmanager if first request fails
…ot/cherry-pick-4899-to-release-2.4 [release-2.4] 🐛 fix/network/rtb: delete rtb handling err when failed to create routes
…ot/cherry-pick-4866-to-release-2.4 [release-2.4] 🐛 fix: create ingress rules from all load balancers
…ot/cherry-pick-4873-to-release-2.4 [release-2.4] 🐛 ROSA: fix auto scale and multi zone compute nodes
… dhcpOpts When a VPC sets a DHCPOption's domain-name with a custom DNS name, it's being ignored. Now, with this PR, ensure that during instance creation, the controller checks the DHCPOptions and sets the proper PrivateDNSName. Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
…CPBUGS-29391 [release-2.4] 🐛 fix: Fix instance PrivateDNSName when domain-name is set in dhcpOpts
damdo
force-pushed
the
rebase-atop-v2.4.2
branch
from
89fd5d6
to
b5a344e
Compare
|
/retest |
|
@damdo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
damdo
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@damdo: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nrb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-aws-cluster-api-controllers-container-v4.16.0-202404151450.p0.g63025f8.assembly.stream.el9 for distgit ose-aws-cluster-api-controllers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.