Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update and run scale down patches #84

Merged
merged 1 commit into from Oct 24, 2018

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Oct 24, 2018

Update and apply the scale down patches

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 24, 2018
@ingvagabund
Copy link
Member

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2018
@ingvagabund
Copy link
Member

error: unable to signal to artifacts container to terminate in pod e2e-aws, triggering deletion: could not run remote command: unable to upgrade connection: container not found ("artifacts") looks like internal error, not related.
/test e2e-aws

@ingvagabund
Copy link
Member

error: unable to check your credentials - pass --skip-check to bypass this error: Get https://registry.svc.ci.openshift.org/v2/: net/http: TLS handshake timeout
/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit 63ef3ac into openshift:master Oct 24, 2018
@wking
Copy link
Member

wking commented Nov 30, 2018

Cross-linking kubernetes-sigs/cluster-api#513, which seems to be the upstream side of the "Delete specific machine from a machineset when scaling down" patch. I don't see an upstream commit for "Sort machines before syncing", but maybe it's been squashed in or some such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants