Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-27450: add a snyk configuration file #299

Merged
merged 1 commit into from Mar 1, 2024

Conversation

elmiko
Copy link

@elmiko elmiko commented Feb 8, 2024

This change adds a file to configure the automated snyk security scans.

This change adds a file to configure the automated snyk security scans.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 8, 2024
@openshift-ci-robot
Copy link

@elmiko: This pull request references Jira Issue OCPBUGS-27450, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This change adds a file to configure the automated snyk security scans.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elmiko
Copy link
Author

elmiko commented Feb 8, 2024

@damdo ptal, i excluded the templates directory because i didn't think we are using it, just want to confirm.

@elmiko
Copy link
Author

elmiko commented Feb 8, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 8, 2024
@openshift-ci-robot
Copy link

@elmiko: This pull request references Jira Issue OCPBUGS-27450, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 8, 2024
@JoelSpeed
Copy link

/approve
/lgtm

@racheljpg
Copy link

/retest-required

@racheljpg
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@nrb
Copy link

nrb commented Feb 29, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 131ebad and 2 for PR HEAD 17d5ad8 in total

@JoelSpeed
Copy link

/override ci/prow/e2e-azure-serial

Snyk configuration does not affect the E2E jobs

Copy link

openshift-ci bot commented Mar 1, 2024

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-azure-serial

In response to this:

/override ci/prow/e2e-azure-serial

Snyk configuration does not affect the E2E jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Mar 1, 2024

@elmiko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 03b594c into openshift:master Mar 1, 2024
7 checks passed
@openshift-ci-robot
Copy link

@elmiko: Jira Issue OCPBUGS-27450: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27450 has been moved to the MODIFIED state.

In response to this:

This change adds a file to configure the automated snyk security scans.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-cluster-api-controllers-container-v4.16.0-202403011138.p0.g03b594c.assembly.stream.el9 for distgit ose-azure-cluster-api-controllers.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants