New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.6] Bug 1886582: Remove Node finalizer first on delete #123
[release-4.6] Bug 1886582: Remove Node finalizer first on delete #123
Conversation
Ensure the Node finalizer is removed even if the Host used by the Machine has already been deleted by some external means.
@openshift-cherrypick-robot: Bugzilla bug 1886028 has been cloned as Bugzilla bug 1886582. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1886582, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label group-lead-approved |
@hardys: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/refresh |
Tide is now correctly saying that this needs the cherry-pick-approved label, but I suspect it is not on anybody's list to look at because it doesn't have the do-not-merge/cherry-pick-not-approved label. Let's see if we can convince the bot to add it. |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1886582 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hack/unit: Set a default value for ARTIFACTS
This is an automated cherry-pick of #122
/assign zaneb