Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update machine/host secret with full rendered ignition from MCO #127

Closed
wants to merge 2 commits into from
Closed

Update machine/host secret with full rendered ignition from MCO #127

wants to merge 2 commits into from

Conversation

kirankt
Copy link

@kirankt kirankt commented Nov 15, 2020

This PR creates a new per machine userData secret to contain the full rendered ignition, which is used by the BaremetalOperator to build the config drive to configure the host. The original secret reference which is initially created by the openshift installer only contains pointer/stub ignition. The new secret is owned by the Machine and will be deleted when the machine is removed

co-authored-by: Steve Hardy shardy@redhat.com

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2020
@kirankt kirankt changed the title [WIP] Update machine/host secret with full rendered ignition from MCO Update machine/host secret with full rendered ignition from MCO Nov 20, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2020
@kirankt
Copy link
Author

kirankt commented Nov 20, 2020

/assign @hardys

@kirankt
Copy link
Author

kirankt commented Nov 20, 2020

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kirankt
To complete the pull request process, please assign hardys after the PR has been reviewed.
You can assign the PR to them by writing /assign @hardys in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kirankt
Copy link
Author

kirankt commented Nov 30, 2020

RBAC PR: openshift/machine-api-operator#766

@kirankt
Copy link
Author

kirankt commented Dec 5, 2020

Depends on openshift/installer#4456, which creates the secret asset for this PR to work correctly

@openshift-merge-robot
Copy link

@kirankt: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi e396577 link /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-ovn-ipv6 e396577 link /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kirankt
Copy link
Author

kirankt commented Jan 28, 2021

Obsolete. Need a different approach. MCO's rendered ignition is not complete. Additional duplication of work required to match the ignition fetched from the MachineConfigServer (MCS).
/close

@kirankt kirankt closed this Jan 28, 2021
honza pushed a commit to honza/cluster-api-provider-baremetal that referenced this pull request Feb 7, 2022
…-documentation

📖  Add unhealthy annotation documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants