New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update machine/host secret with full rendered ignition from MCO #127
Conversation
/assign @hardys |
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kirankt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RBAC PR: openshift/machine-api-operator#766 |
Depends on openshift/installer#4456, which creates the secret asset for this PR to work correctly |
@kirankt: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Obsolete. Need a different approach. MCO's rendered ignition is not complete. Additional duplication of work required to match the ignition fetched from the MachineConfigServer (MCS). |
…-documentation 📖 Add unhealthy annotation documentation
This PR creates a new per machine userData secret to contain the full rendered ignition, which is used by the BaremetalOperator to build the config drive to configure the host. The original secret reference which is initially created by the openshift installer only contains pointer/stub ignition. The new secret is owned by the Machine and will be deleted when the machine is removed
co-authored-by: Steve Hardy shardy@redhat.com