Allow actuator.Exists() to find a host in the unmanaged state

[asalkeld]

This will enable the assisisted installer host to be linked

[asalkeld]

2020/12/10 01:04:27 Checking if machine covid-assisted-instal-6bztc-worker-0-lghc6 exists.
2020/12/10 01:04:27 Machine covid-assisted-instal-6bztc-worker-0-lghc6 does not have provisioned Host (openshift-worker-1 is unmanaged).

[hardys]

Thanks @asalkeld - since we're past feature-freeze this will need a bz to land - I think we need some further discussion with @zaneb and @dhellmann though, as although IIRC we added the unmanaged state specifically for this use-case, there was some concern that unless the host is marked externally provisioned, a day-2 action of adding BMC credentials could trigger inspection.

I'm not certain if that will happen if we've already set the status via the annotation? But anyway we probably need to agree the expected provisioning status which will determine whether we need this change or not.

[dhellmann]

Thanks @asalkeld - since we're past feature-freeze this will need a bz to land - I think we need some further discussion with @zaneb and @dhellmann though, as although IIRC we added the unmanaged state specifically for this use-case, there was some concern that unless the host is marked externally provisioned, a day-2 action of adding BMC credentials could trigger inspection.

I'm not certain if that will happen if we've already set the status via the annotation? But anyway we probably need to agree the expected provisioning status which will determine whether we need this change or not.

Can we tell from looking at the Machine that it was created by the assisted installer? If so, we could check that the host is unmanaged and has externallyProvisioned set. If we can't tell an assisted installer Machine from a regular one, I am concerned that we might end up selecting an unprovisionable host for a real IPI case. Maybe we should use a separate loop, after this loop, to give provisionable hosts priority?

[zaneb]

This is fine. It's in Exists() (not chooseHost()), so it's only called to see whether a Host already linked to the Machine still exists and hasn't been deprovisioned.
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asalkeld, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zaneb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.