Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1907614: Update kubernetes deps to 1.20 #132

Merged
merged 5 commits into from Jan 26, 2021
Merged

Bug 1907614: Update kubernetes deps to 1.20 #132

merged 5 commits into from Jan 26, 2021

Conversation

sadasu
Copy link

@sadasu sadasu commented Jan 12, 2021

No description provided.

@sadasu
Copy link
Author

sadasu commented Jan 12, 2021

/retitle Bug 1907614: Update kubernetes deps to 1.20

@openshift-ci-robot openshift-ci-robot changed the title Update kubernetes deps to 1.20 Bug 1907614: Update kubernetes deps to 1.20 Jan 12, 2021
@openshift-ci-robot
Copy link

@sadasu: This pull request references Bugzilla bug 1907614, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1907614: Update kubernetes deps to 1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 12, 2021
@sadasu
Copy link
Author

sadasu commented Jan 18, 2021

/retest

1 similar comment
@sadasu
Copy link
Author

sadasu commented Jan 21, 2021

/retest

zaneb
zaneb reviewed Jan 21, 2021
View reviewed changes
pkg/manager/wrapper/bmh_mapper.go Outdated Show resolved Hide resolved
pkg/manager/wrapper/node_mapper.go Outdated Show resolved Hide resolved
pkg/controller/machineset/mapper.go Outdated Show resolved Hide resolved
pkg/controller/machineset/machineset_controller.go Outdated Show resolved Hide resolved
@sadasu
Updates to accomodate changes to handler.EnqueueRequestsFromMapFunc
d28ecd9
@sadasu
Updates to accomodate log package changes in controller-runtime
3ff29cb
@sadasu
Updates to handle changes to handle.MapObject and Reconcile()
db59a46 
handle.MapObject was removed in controller-runtime v0.7.0 and has
been replaced with client.Object.
Reconcile() now takes the context as its 1st arguement. This is also
required to start using controller-runtime v0.7.0.
@zaneb
Copy link
Member

zaneb commented Jan 26, 2021

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2021
@sadasu
Copy link
Author

sadasu commented Jan 26, 2021

@kirankt Could you PTAL? Needs a lgtm

@kirankt
Copy link

kirankt commented Jan 26, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kirankt, sadasu, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4e254d0 into openshift:master Jan 26, 2021
@openshift-ci-robot
Copy link

@sadasu: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1907614 has not been moved to the MODIFIED state.

In response to this:

Bug 1907614: Update kubernetes deps to 1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kirankt kirankt mentioned this pull request Jan 27, 2021
Closed
@hardys hardys mentioned this pull request Feb 15, 2021
Merged
honza pushed a commit to honza/cluster-api-provider-baremetal that referenced this pull request Feb 7, 2022
@metal3-io-bot
Merge pull request openshift#132 from Nordix/v1a4-mael
455897d 
🌱 Tilt: Use external providers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaneb zaneb zaneb left review comments

@hardys hardys Awaiting requested review from hardys

@mhrivnak mhrivnak Awaiting requested review from mhrivnak

Assignees

@kirankt kirankt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sadasu @openshift-ci-robot @zaneb @kirankt @openshift-merge-robot