Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-29177: Extend metal3remediation aggregation role #211

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #210

/assign slintes

- Node Healthcheck controller is going to watch templates, in order to
  update its status in case a template is deleted
- NHC is also watching the remediation CRs, in order to update its
  status when the CR is finally deleted after the metal3 controller
  removed the finalizer
- NHC is updating CRs with an annotation (unused by metal3 controller,
  but we'd like to prevent error messages in NHC controller)

Signed-off-by: Marc Sluiter <msluiter@redhat.com>
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-28838 has been cloned as Jira Issue OCPBUGS-29177. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-29177: Extend metal3remediation aggregation role

In response to this:

This is an automated cherry-pick of #210

/assign slintes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-28838: Extend metal3remediation aggregation role [release-4.14] OCPBUGS-29177: Extend metal3remediation aggregation role Feb 7, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Feb 7, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-29177, which is invalid:

  • expected dependent Jira Issue OCPBUGS-28838 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #210

/assign slintes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 7, 2024
@openshift-ci openshift-ci bot requested review from honza and zaneb February 7, 2024 12:05
@iurygregory
Copy link

/retest

@iurygregory
Copy link

/test e2e-metal-ipi-upgrade

@slintes
Copy link
Member

slintes commented Feb 13, 2024

/retest
/jira-refresh

@slintes
Copy link
Member

slintes commented Feb 13, 2024

/jira refresh

@openshift-ci-robot
Copy link

@slintes: An error was encountered querying GitHub for users with public email (asavina@redhat.com) for bug OCPBUGS-29177 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: connect: connection refused

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@slintes
Copy link
Member

slintes commented Feb 13, 2024

/test e2e-metal-ipi-upgrade
/jira refresh

1 similar comment
@slintes
Copy link
Member

slintes commented Feb 14, 2024

/test e2e-metal-ipi-upgrade
/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 14, 2024
@openshift-ci-robot
Copy link

@slintes: This pull request references Jira Issue OCPBUGS-29177, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-28838 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-28838 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (asavina@redhat.com), skipping review request.

In response to this:

/test e2e-metal-ipi-upgrade
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dtantsur
Copy link
Member

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 19, 2024
Copy link

openshift-ci bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@jadhaj
Copy link

jadhaj commented Feb 20, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 20, 2024
@elfosardo
Copy link

/retest

@elfosardo
Copy link

/lgtm
all in all failure does not depend on this change

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4394e1f into openshift:release-4.14 Feb 22, 2024
10 of 11 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29177: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29177 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #210

/assign slintes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build baremetal-machine-controller-container-v4.14.0-202402220909.p0.g4394e1f.assembly.stream.el8 for distgit baremetal-machine-controller.
All builds following this will include this PR.

@slintes
Copy link
Member

slintes commented Feb 22, 2024

last but not least :)

/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link
Author

@slintes: new pull request created: #212

In response to this:

last but not least :)

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.14.0-0.nightly-2024-02-22-202606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants