New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: update openshift/cluster-api #23
vendor: update openshift/cluster-api #23
Conversation
/test images got killed in the middle for some reason ... |
not sure about this |
This pulls in the latest changes from the openshift-4.0-cluster-api-0.0.0-alpha.4 branch of openshift/cluster-api.
797cb23
to
cf7bf62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait for the CI job to pass before leaving a formal go-ahead, but this looks good.
@dhellmann All of the CI jobs have passed now. The last one (tide) is the one that runs only after it's approved for merging |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, russellb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR updates our vendored copy of cluster-api to the latest version from the openshift-4.0-cluster-api-0.0.0-alpha.4 branch.
Once this merges, I will backport it to the release-4.1 branch.
master will then need to get updated to a 4.2 branch of openshift/cluster-api, but this PR is the first step.