fixes broken make manifests, which was also breaking make unit.
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kustomize was interpreting the path argument `github.com/openshift/cluster-api/config` as a URL instead of a relative file path. It was doing something with git to retrieve files from github, put them in a temporary directory (hence the confusing error message about a directory in /tmp/), then failing to find what it expected. fixes #48
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
|
/lgtm |
|
@zaneb: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, mhrivnak, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
honza
pushed a commit
to honza/cluster-api-provider-baremetal
that referenced
this pull request
Feb 7, 2022
🐛 UpdateObject function should operate on a deepcopy of the object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kustomize was interpreting the path argument
github.com/openshift/cluster-api/configas a URL instead of a relative filepath. It was doing something with git to retrieve files from github, put them
in a temporary directory (hence the confusing error message about a directory
in /tmp/), then failing to find what it expected.
fixes #48