Bug 1816514: updates vendored cluster-api to branch release-4.5 #63
Conversation
A previous change updating controller-runtime had a side effect of causing metrics to be turned on by default in the controller-manager, which is part of the vendored cluster-api code. That change caused a conflict with the machine-controller because both were deployed as containers in the same Pod, and both tried to listen on the default metrics port of 8080. The update introduced by this commit fixes that because the current cluster-api code disables metrics in the controller-manager.
openshift-ci-robot
added
the
approved
|
/test e2e-metal-ipi |
1 similar comment
|
/test e2e-metal-ipi |
|
/close |
|
@stbenjam: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@stbenjam: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Install passed, the log gathering for CI is still broken /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhrivnak, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override e2e-metal-ipi |
|
@stbenjam: stbenjam unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override e2e-metal-ipi |
|
@mhrivnak: /override requires a failed status context to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-metal-ipi |
|
@mhrivnak: Overrode contexts on behalf of mhrivnak: ci/prow/e2e-metal-ipi In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mhrivnak: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retitle Bug 1816514: updates vendored cluster-api to branch release-4.5 |
openshift-ci-robot
changed the title
|
@mhrivnak: All pull requests linked via external trackers have merged. Bugzilla bug 1816514 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📖 Fix version in docs
A previous change updating controller-runtime had a side effect of causing
metrics to be turned on by default in the controller-manager, which is part of
the vendored cluster-api code. That change caused a conflict with the
machine-controller because both were deployed as containers in the same Pod,
and both tried to listen on the default metrics port of 8080.
The update introduced by this commit fixes that because the current cluster-api
code disables metrics in the controller-manager.