Switch openshift/cluster-api branch.

[russellb]

Switch the openshift/cluster-api branch to
openshift-4.0-cluster-api-0.0.0-alpha.4, which contains the latest
rebase of cluster-api. Providers are not to be using the master
branch of openshift/cluster-api.

[mhrivnak]

It looks like the AWS provider is just using the https://github.com/openshift/cluster-api/tree/openshift-4.0-cluster-api-0.0.0-alpha.4 branch, which includes the patch. That branch is also using 1.13 kube code. You should be able to change that in Gopkg.toml, run dep ensure -u github.com/openshift/cluster-api, and then have the patch.

That said, I don't know what the expectations are around that branch or why it includes stuff not in master, but using that branch would get us to the same state as the aws and libvert providers.

[ingvagabund]

As @mhrivnak describes. The master branch of openshift/cluster-api is considered dormant. Only https://github.com/openshift/cluster-api/tree/openshift-4.0-cluster-api-0.0.0-alpha.4 branch is supposed to be imported.

Please see https://github.com/openshift/cluster-api-provider-aws/blob/master/Gopkg.toml#L31-L33

[mhrivnak]

/lgtm

[openshift-ci-robot]

@mhrivnak: changing LGTM is restricted to assignees, and only openshift/cluster-api-provider-baremetal repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dhellmann]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, mhrivnak, russellb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dhellmann,russellb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment