Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1862875: remove machine finalizer from host when deleting machine #94

Merged
merged 1 commit into from Aug 20, 2020
Merged

Bug 1862875: remove machine finalizer from host when deleting machine #94

merged 1 commit into from Aug 20, 2020

Conversation

dhellmann
Copy link

This PR depends on #93 and should be rebased after it merges

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 3, 2020
@openshift-ci-robot
Copy link

@dhellmann: This pull request references Bugzilla bug 1862875, which is invalid:

  • expected dependent Bugzilla bug 1837505 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1862875: remove machine finalizer from host when deleting machine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2020
@dhellmann
Copy link
Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 17, 2020
@openshift-ci-robot
Copy link

@dhellmann: This pull request references Bugzilla bug 1862875, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1837505 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1837505 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Author

@zaneb @hardys could you take a look at this PR now that the 4.6 version has landed? thanks!

@zaneb

This comment has been minimized.

Sign in to view
@zaneb
Copy link
Member

zaneb commented Aug 17, 2020

Actually, I'll move that comment to #93. This PR is just for the last patch, which
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2020
@jwforres jwforres mentioned this pull request Aug 19, 2020
Merged
@dhellmann
remove machine finalizer from host when deleting machine
acf5a6f 
When a Machine is deleted, any host it was using should have all
associations with Machines removed. We were removing the explicit
links to the machine, but not the finalizer that the machine
controller added. This change removes the finalizer so that hosts that
are no longer being consumed by a machine can be deleted.

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
(cherry picked from commit c2cb687)
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@dhellmann
Copy link
Author

/hold clear

@dhellmann
Copy link
Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2020
@dhellmann
Copy link
Author

@jwforres this one has been rebased

@dhellmann
Copy link
Author

@zaneb could you take another look at this, now that it has been rebased, please?

@zaneb
Copy link
Member

zaneb commented Aug 20, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jwforres jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 20, 2020
@openshift-merge-robot openshift-merge-robot merged commit d243d30 into openshift:release-4.5 Aug 20, 2020
@openshift-ci-robot
Copy link

@dhellmann: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-baremetal#94. Bugzilla bug 1862875 has been moved to the MODIFIED state.

In response to this:

Bug 1862875: remove machine finalizer from host when deleting machine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

honza pushed a commit to honza/cluster-api-provider-baremetal that referenced this pull request Feb 7, 2022
@metal3-io-bot
Merge pull request openshift#94 from Nordix/v1a4-mael
1d84122 
🐛 Fix NPE when gateway is absent from IPPool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardys hardys Awaiting requested review from hardys

@mhrivnak mhrivnak Awaiting requested review from mhrivnak

Assignees

@zaneb zaneb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dhellmann @openshift-ci-robot @zaneb @jwforres @openshift-merge-robot