Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1877743: Update openshift/machine-api-operator and pull in k8s 1.19 #96

Merged
merged 2 commits into from Sep 14, 2020
Merged

Bug 1877743: Update openshift/machine-api-operator and pull in k8s 1.19 #96

merged 2 commits into from Sep 14, 2020

Conversation

zaneb
Copy link
Member

@zaneb zaneb commented Aug 12, 2020

Ensure we are vendoring the latest MAO.

@zaneb zaneb marked this pull request as draft August 12, 2020 16:54
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2020
@zaneb zaneb marked this pull request as ready for review August 12, 2020 17:07
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2020
@zaneb
Copy link
Member Author

zaneb commented Aug 12, 2020

/cc @michaelgugino

michaelgugino
michaelgugino suggested changes Aug 12, 2020
View reviewed changes
go.mod Outdated
github.com/gobuffalo/flect v0.2.1 // indirect
github.com/google/gofuzz v1.2.0 // indirect
github.com/json-iterator/go v1.1.10 // indirect
github.com/mattn/go-colorable v0.1.7 // indirect
github.com/metal3-io/baremetal-operator v0.0.0
github.com/onsi/gomega v1.9.0
github.com/openshift/machine-api-operator v0.2.1-0.20200721125631-d234cceb5de1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This did not appear to update machine-api-operator depedency, actually.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent point 🤦

@zaneb
Copy link
Member Author

zaneb commented Aug 12, 2020

/retest

michaelgugino
michaelgugino approved these changes Aug 12, 2020
View reviewed changes
Copy link

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zaneb
Copy link
Member Author

zaneb commented Aug 21, 2020

/assign @dhellmann

dhellmann
dhellmann reviewed Aug 24, 2020
View reviewed changes
Copy link

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 24, 2020
@dhellmann
Copy link

@zaneb it looks like this needs to be linked to a bug report

@zaneb
Copy link
Member Author

zaneb commented Sep 11, 2020

This is likely to be superseded by #109.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2020
@zaneb zaneb mentioned this pull request Sep 12, 2020
Closed
@JoelSpeed
Copy link

This now includes the changes from #109 and covers the same purpose, lets use this PR to get the changes merged. You can use bug 1877743 for this

@zaneb
Copy link
Member Author

zaneb commented Sep 14, 2020

/retitle Bug 1877743: Update openshift/machine-api-operator and pull in k8s 1.19

@openshift-ci-robot openshift-ci-robot changed the title Update openshift/machine-api-operator Bug 1877743: Update openshift/machine-api-operator and pull in k8s 1.19 Sep 14, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 14, 2020
@openshift-ci-robot
Copy link

@zaneb: This pull request references Bugzilla bug 1877743, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1877743: Update openshift/machine-api-operator and pull in k8s 1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 14, 2020
@dhellmann
Copy link

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, michaelgugino, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 695af14 into openshift:master Sep 14, 2020
@openshift-ci-robot
Copy link

@zaneb: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1877743 has not been moved to the MODIFIED state.

In response to this:

Bug 1877743: Update openshift/machine-api-operator and pull in k8s 1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 17, 2020
Merged
Merged
Merged
honza pushed a commit to honza/cluster-api-provider-baremetal that referenced this pull request Feb 7, 2022
@metal3-io-bot
Merge pull request openshift#96 from Nordix/unhealthy-node-handling-jan
5953cae 
✨ PR prevents the use of BMH annotated as unhealthy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann dhellmann left review comments

@michaelgugino michaelgugino michaelgugino approved these changes

@mhrivnak mhrivnak Awaiting requested review from mhrivnak

@russellb russellb Awaiting requested review from russellb

Assignees

@dhellmann dhellmann

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zaneb @dhellmann @JoelSpeed @openshift-ci-robot @michaelgugino @openshift-merge-robot