Bug 1869318: Remove finalizer from Node on delete

[zaneb]

Since 4dba29b we add a finalizer on the
Node corresponding to a Machine, but we only remove it when the Node is
being deleted while the Machine is still active. Remove it when the
Machine is being deleted, otherwise the Node can never be removed.

[openshift-ci-robot]

@zaneb: This pull request references Bugzilla bug 1869318, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1869318: Remove finalizer from Node on delete

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zaneb]

/assign @dhellmann
/cc @hardys
/cc @mhrivnak

[dhellmann]

/lgtm

[dhellmann]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dhellmann]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@zaneb: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-baremetal#97. Bugzilla bug 1869318 has been moved to the MODIFIED state.

In response to this:

Bug 1869318: Remove finalizer from Node on delete

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stbenjam]

/cherry-pick release-4.5

[openshift-cherrypick-robot]

@stbenjam: #97 failed to apply on top of branch "release-4.5":

Applying: Remove finalizer from Node on delete
Using index info to reconstruct a base tree...
M	pkg/cloud/baremetal/actuators/machine/actuator.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/cloud/baremetal/actuators/machine/actuator.go
CONFLICT (content): Merge conflict in pkg/cloud/baremetal/actuators/machine/actuator.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove finalizer from Node on delete
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zaneb]

The bug is not present in release-4.5.