More logging for exists method #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
frobware
reviewed
May 10, 2019
| @@ -49,6 +49,7 @@ func (a *Actuator) Create(ctx context.Context, cluster *clusterv1.Cluster, machi | |||
| } | |||
|
|
|||
| func (a *Actuator) Exists(ctx context.Context, cluster *clusterv1.Cluster, machine *machinev1.Machine) (bool, error) { | |||
| klog.Infof("Checking if machine %v exists", machine.Name) | |||
frobware
reviewed
May 10, 2019
| @@ -58,7 +59,7 @@ func (a *Actuator) Exists(ctx context.Context, cluster *clusterv1.Cluster, machi | |||
| return false, fmt.Errorf("failed to create scope for machine %q: %v", machine.Name, err) | |||
| } | |||
| defer scope.Close() | |||
| return newReconciler(scope).instanceExists() | |||
| return newReconciler(scope).Exists() | |||
There was a problem hiding this comment.
Does Exists() need to be exported?
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
RadekManak
pushed a commit
to RadekManak/cluster-api-provider-gcp
that referenced
this pull request
Apr 12, 2023
✨ Refactor observedGeneration
RadekManak
pushed a commit
to RadekManak/cluster-api-provider-gcp
that referenced
this pull request
Apr 12, 2023
…enshift-4.13-ose-cluster-kube-cluster-api-operator Updating ose-cluster-kube-cluster-api-operator images to be consistent with ART
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.