New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG 1867262: Support networks shared from a different project #113
BUG 1867262: Support networks shared from a different project #113
Conversation
This allows users to specify an alternative project for the network that the VM is created within. This allows for shared VPCs.
@JoelSpeed: This pull request references Bugzilla bug 1867262, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update, I have tested this in an openshift 4.6 cluster built via UPI into a shared VPC. I had to also add the The only addition required for this was for me to manually allow the Machine API google service account created for the cluster to have the "Compute Network User" role assigned to it in the Host (network host) project. The specific required permission was |
/test unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me Joel, thanks for the hard work!
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-gcp |
1 similar comment
/test e2e-gcp |
@JoelSpeed: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-gcp#113. Bugzilla bug 1867262 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.5 |
@JoelSpeed: new pull request created: #116 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This allows users to specify an alternative project for the network that the VM is created within. This allows for shared VPCs.
I have yet to test this in a real cluster, I want to verify this works before allowing it to merge, hence holding. This shouldn't block the review process though.
/hold