Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1864352: Add leader election mechanism to release 4.5 #114

Merged
merged 3 commits into from Sep 17, 2020
Merged

Bug 1864352: Add leader election mechanism to release 4.5 #114

merged 3 commits into from Sep 17, 2020

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Aug 11, 2020 •
edited

This change brings in 3 cherry-pick commits which add leader election to this controller.

8b1645c
8c87213
3739cfa

@Danil-Grigorev @elmiko
Implement leader election for gcp provider
c8bbf6b
@Danil-Grigorev @elmiko
Increate leader election lease time
6232d28 
The machine-api-controller components are refreshing their lease more
than all other components combined. Bringing this to 90s each, will
decrease etcd writes at idle.
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 11, 2020
@openshift-ci-robot
Copy link
Contributor

@elmiko: This pull request references Bugzilla bug 1864352, which is invalid:

  • expected dependent Bugzilla bug 1861896 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is CLOSED (CURRENTRELEASE) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1864352: Add leader election mechanism

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko elmiko mentioned this pull request Aug 11, 2020
Merged
@elmiko
Copy link
Contributor Author

elmiko commented Aug 12, 2020

i'm putting a hold on this as i would like to make sure we include these commits when they land on the master branch, #115
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2020
@Danil-Grigorev @elmiko
Slow the default lease retry and renew rate for machine controller
906034b 
Prevent machine controllers from writing in etcd at idle too often
by setting 120s lease, 20s retry and 110s deadline on all renewals.
Higher values cause tests to flake.
BZ 1858403
@openshift-ci-robot
Copy link
Contributor

@elmiko: This pull request references Bugzilla bug 1864352, which is invalid:

  • expected dependent Bugzilla bug 1861896 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1864352: Add leader election mechanism

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Contributor Author

elmiko commented Aug 26, 2020

removing the hold as #115 has merged
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2020
@elmiko
Copy link
Contributor Author

elmiko commented Aug 27, 2020

/retitle Bug 1864352: Add leader election mechanism to release 4.5

@openshift-ci-robot openshift-ci-robot changed the title Bug 1864352: Add leader election mechanism Bug 1864352: Add leader election mechanism to release 4.5 Aug 27, 2020
@elmiko
Copy link
Contributor Author

elmiko commented Sep 8, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 8, 2020
@openshift-ci-robot
Copy link
Contributor

@elmiko: This pull request references Bugzilla bug 1864352, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1861896 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1861896 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Danil-Grigorev
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2020
@Danil-Grigorev
Copy link
Contributor

@JoelSpeed @enxebre Need you guys to approve this, as I was not in approvers in 4.5 release :D Sorry @elmiko

@JoelSpeed
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2020
@markmc
Copy link

markmc commented Sep 17, 2020

Landed this for aws and baremetal last week. Looks justified to avoid a nasty failure scenario.

@markmc markmc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 17, 2020
@elmiko
Copy link
Contributor Author

elmiko commented Sep 17, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit 90e92ed into openshift:release-4.5 Sep 17, 2020
@openshift-ci-robot
Copy link
Contributor

@elmiko: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1864352 has not been moved to the MODIFIED state.

In response to this:

Bug 1864352: Add leader election mechanism to release 4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko elmiko deleted the add-leader-election/release-4.5 branch May 19, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@Danil-Grigorev Danil-Grigorev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@elmiko @openshift-ci-robot @Danil-Grigorev @JoelSpeed @markmc @openshift-merge-robot