Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1941563: Ensure response body is closed when we are finished with the request #154

Merged
merged 1 commit into from Mar 24, 2021
Merged

[release-4.6] Bug 1941563: Ensure response body is closed when we are finished with the request #154

merged 1 commit into from Mar 24, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #151

/assign JoelSpeed

@JoelSpeed
Ensure response body is closed when we are finished with the request
9184618 
When creating an http request in go, this sets two goroutines in the
background running. If the body is not closed properly, these goroutines
are leaked. This leads to a gradual increase in memory used by the
application over time. We must ensure we always close response bodies
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 22, 2021
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1935636 has been cloned as Bugzilla bug 1941563. Retitling PR to link against new bug.
/retitle [release-4.6] [release-4.7] Bug 1941563: Ensure response body is closed when we are finished with the request

In response to this:

[release-4.6] [release-4.7] Bug 1935636: Ensure response body is closed when we are finished with the request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] [release-4.7] Bug 1935636: Ensure response body is closed when we are finished with the request [release-4.6] [release-4.7] Bug 1941563: Ensure response body is closed when we are finished with the request Mar 22, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Mar 22, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1941563, which is invalid:

  • expected dependent Bugzilla bug 1935636 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] [release-4.7] Bug 1941563: Ensure response body is closed when we are finished with the request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 22, 2021
@JoelSpeed
Copy link
Contributor

/retitle [release-4.6] Bug 1941563: Ensure response body is closed when we are finished with the request

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] [release-4.7] Bug 1941563: Ensure response body is closed when we are finished with the request [release-4.6] Bug 1941563: Ensure response body is closed when we are finished with the request Mar 22, 2021
@lobziik
Copy link
Contributor

lobziik commented Mar 22, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2021
alexander-demicev
alexander-demicev approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2021
Danil-Grigorev
Danil-Grigorev approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev, Danil-Grigorev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Danil-Grigorev,alexander-demichev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoelSpeed
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@JoelSpeed: This pull request references Bugzilla bug 1941563, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1935636 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1935636 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 22, 2021
@jwforres jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit 9b15b11 into openshift:release-4.6 Mar 24, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1941563 has not been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1941563: Ensure response body is closed when we are finished with the request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-demicev alexander-demicev alexander-demicev approved these changes

@Danil-Grigorev Danil-Grigorev Danil-Grigorev approved these changes

@elmiko elmiko Awaiting requested review from elmiko

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

Assignees

@lobziik lobziik

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @JoelSpeed @lobziik @alexander-demicev @Danil-Grigorev @jwforres @openshift-merge-robot