Make delete async #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
|
michaelgugino
suggested changes
May 30, 2019
openshift-ci-robot
added
size/M
frobware
force-pushed
the
make-delete-async
branch
from
7fc19a8
to
2773e6c
Compare
michaelgugino
approved these changes
May 30, 2019
enxebre
reviewed
May 31, 2019
|
/hold Waiting on #25 |
openshift-ci-robot
added
the
do-not-merge/hold
frobware
force-pushed
the
make-delete-async
branch
from
2773e6c
to
ab20cf8
Compare
Testing is minimal and would need further rework which can be done as a follow-up PR.
This function and the constants it references are no longer used.
frobware
force-pushed
the
make-delete-async
branch
from
ab20cf8
to
6bbaf1a
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/hold Manual / sanity testing. |
openshift-ci-robot
added
the
do-not-merge/hold
This was introduced in PR openshift#25.
|
Runtime behaviour: I0531 13:37:34.187256 1703 controller.go:193] Reconciling machine "amcdermo-test-gcp-1" triggers delete
I0531 13:37:34.187268 1703 actuator.go:89] Deleting machine amcdermo-test-gcp-1
I0531 13:37:34.712075 1703 reconciler.go:237] Machine "amcdermo-test-gcp-1" already exists
I0531 13:37:35.256189 1703 reconciler.go:261] machine "amcdermo-test-gcp-1" status is exists, requeuing...
E0531 13:37:35.256266 1703 controller.go:207] Failed to delete machine "amcdermo-test-gcp-1": requeue in: 20s
I0531 13:37:35.256297 1703 controller.go:346] Actuator returned requeue-after error: requeue in: 20s
I0531 13:37:55.256673 1703 controller.go:129] Reconciling Machine "amcdermo-test-gcp-1"
I0531 13:37:55.256724 1703 controller.go:292] Machine "amcdermo-test-gcp-1" in namespace "test-gcp" doesn't specify "cluster.k8s.io/cluster-name" label, assuming nil cluster
I0531 13:37:55.256763 1703 controller.go:193] Reconciling machine "amcdermo-test-gcp-1" triggers delete
I0531 13:37:55.256788 1703 actuator.go:89] Deleting machine amcdermo-test-gcp-1
I0531 13:37:55.822772 1703 reconciler.go:237] Machine "amcdermo-test-gcp-1" already exists
I0531 13:37:56.232196 1703 reconciler.go:261] machine "amcdermo-test-gcp-1" status is exists, requeuing...
E0531 13:37:56.232281 1703 controller.go:207] Failed to delete machine "amcdermo-test-gcp-1": requeue in: 20s
I0531 13:37:56.232315 1703 controller.go:346] Actuator returned requeue-after error: requeue in: 20s
I0531 13:38:16.232527 1703 controller.go:129] Reconciling Machine "amcdermo-test-gcp-1"
I0531 13:38:16.232567 1703 controller.go:292] Machine "amcdermo-test-gcp-1" in namespace "test-gcp" doesn't specify "cluster.k8s.io/cluster-name" label, assuming nil cluster
I0531 13:38:16.232579 1703 controller.go:193] Reconciling machine "amcdermo-test-gcp-1" triggers delete
I0531 13:38:16.232597 1703 actuator.go:89] Deleting machine amcdermo-test-gcp-1
I0531 13:38:16.780866 1703 reconciler.go:234] Machine "amcdermo-test-gcp-1" is considered as non existent as its status is "TERMINATED"
I0531 13:38:16.780913 1703 reconciler.go:255] Machine amcdermo-test-gcp-1 not found during delete, skipping
I0531 13:38:16.894092 1703 controller.go:226] Machine "amcdermo-test-gcp-1" deletion successful |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing is minimal and would need further rework which can be done as
a follow-up PR.