Manage status #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
enxebre
commented
May 9, 2019
enxebre
commented
- Add status API types
- Create proper struct type <-> rawExtension methods and tests for providerSpec and providerStatus
- Add providerID and providerStatus to machine scope and use new struct type <-> rawExtension methods
- Add reconcileMachineWithCloudState() to be called on Create for now
… type <-> rawExtension methods
frobware
reviewed
May 9, 2019
| @@ -35,6 +36,7 @@ func newReconciler(scope *machineScope) *Reconciler { | |||
|
|
|||
| // Create creates machine if and only if machine exists, handled by cluster-api | |||
| func (r *Reconciler) create() error { | |||
| defer r.reconcileMachineWithCloudState() | |||
There was a problem hiding this comment.
Can create be called multiple times for r? If so, what happens with the multiple defer calls?
|
/retest |
openshift-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
RadekManak
pushed a commit
to RadekManak/cluster-api-provider-gcp
that referenced
this pull request
Apr 12, 2023
Add API fields for initial implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.