Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1832186: Bump all dependencies to kube 1.18 #82

Merged
merged 1 commit into from May 7, 2020
Merged

Bug 1832186: Bump all dependencies to kube 1.18 #82

merged 1 commit into from May 7, 2020

Conversation

alexander-demicev
Copy link
Contributor

Bump all dependencies to kube 1.18

@JoelSpeed
Copy link
Contributor

This needs the Go 1.13 stuff to be merged first before it will pass tests

@alexander-demicev
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 7, 2020
@alexander-demicev
Copy link
Contributor Author

/retest

1 similar comment
@alexander-demicev
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2020
enxebre
enxebre reviewed May 5, 2020
View reviewed changes
vendor/github.com/openshift/machine-api-operator/pkg/controller/machine/controller.go Outdated
}
return reconcile.Result{}, err
}

func isInvalidMachineConfigurationError(err error) bool {
var machineError *MachineError
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to be brining old code?

enxebre
enxebre reviewed May 5, 2020
View reviewed changes
go.mod Outdated
@@ -5,20 +5,19 @@ go 1.13
require (
github.com/blang/semver v3.5.1+incompatible
github.com/go-logr/logr v0.1.0
github.com/onsi/ginkgo v1.12.0
github.com/onsi/ginkgo v1.11.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why downgrading ginkgo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad rebase :D

@enxebre
Copy link
Member

enxebre commented May 6, 2020

/approve

@enxebre
Copy link
Member

enxebre commented May 6, 2020

can you please tag a bz?

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2020
@alexander-demicev alexander-demicev changed the title Bump all dependencies to kube 1.18 Bug 1832186: Bump all dependencies to kube 1.18 May 6, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 6, 2020
@openshift-ci-robot
Copy link
Contributor

@alexander-demichev: This pull request references Bugzilla bug 1832186, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1832186: Bump all dependencies to kube 1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2020
@openshift-merge-robot openshift-merge-robot merged commit eb993da into openshift:master May 7, 2020
@openshift-ci-robot
Copy link
Contributor

@alexander-demichev: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

In response to this:

Bug 1832186: Bump all dependencies to kube 1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request May 7, 2020
Merged
RadekManak pushed a commit to RadekManak/cluster-api-provider-gcp that referenced this pull request Apr 12, 2023
@k8s-ci-robot
Merge pull request openshift#82 from alexander-demicev/helm
b5b91df 
✨ Publish helm charts on each operator release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre enxebre left review comments

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alexander-demicev @JoelSpeed @enxebre @openshift-ci-robot @openshift-merge-robot