Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable metrics #94

Merged
merged 2 commits into from Jul 9, 2020
Merged

Enable metrics #94

merged 2 commits into from Jul 9, 2020

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Jun 4, 2020 •
edited

Working on https://issues.redhat.com/browse/OCPCLOUD-784

This PR is adding support for reporting following prometheus metrics and also starting controller-runtime metrics server to make these metrics available for prometheus servers:

  • mapi_instance_create_failed: Total count of "create" cloud api errors
  • mapi_instance_update_failed: Total count of "update" cloud api errors
  • mapi_instance_delete_failed: Total count of "delete" cloud api errors

Labels on these metrics (for GCP):

prometheus.Labels{
  "name": machine.Name,
  "namespace": machine.Namespace,
  "reason": error.Reason,
  "provider_name": "gcp"
}

Depends on PR openshift/machine-api-operator#609 introducing metrics support

JoelSpeed
JoelSpeed reviewed Jun 4, 2020
View reviewed changes
go.mod Outdated
@@ -21,3 +21,5 @@ require (
sigs.k8s.io/controller-tools v0.2.9-0.20200331153640-3c5446d407dd
sigs.k8s.io/yaml v1.2.0
)

replace github.com/openshift/machine-api-operator v0.2.1-0.20200527204437-14e5e0c7d862 => github.com/Danil-Grigorev/machine-api-operator v0.2.1-0.20200604073207-04068f243c6b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer this to be moved back to master openshift before merge
Hold until we can identify whether this is absolutely necessary
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2020
@Danil-Grigorev
Copy link
Contributor Author

/hold Waiting on openshift/machine-api-operator#590

@Danil-Grigorev
Copy link
Contributor Author

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2020
@Danil-Grigorev
Copy link
Contributor Author

/retest

@JoelSpeed
Copy link
Contributor

This PR needs a rebase

And I think we need to revendor MAO here so that we can bring in the metrics package right?

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2020
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
elmiko
elmiko approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

enxebre
enxebre reviewed Jul 1, 2020
View reviewed changes
go.mod Outdated
replace (
sigs.k8s.io/cluster-api-provider-aws => github.com/openshift/cluster-api-provider-aws v0.2.1-0.20200618031251-e16dd65fdd85
sigs.k8s.io/cluster-api-provider-azure => github.com/openshift/cluster-api-provider-azure v0.1.0-alpha.3.0.20200618001858-af08a66b92de
sigs.k8s.io/cluster-api-provider-gcp => github.com/openshift/cluster-api-provider-gcp v0.0.1-0.20200618110630-09cef98ae787
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed at all? this repo is not even a fork.

@enxebre
Copy link
Member

enxebre commented Jul 1, 2020

Can you please include a link to the mao counter PR in the PR desc and the commit desc?
Other than the above and #94 (comment) lgtm

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2020
@Danil-Grigorev
Copy link
Contributor Author

/retest

@Danil-Grigorev
Copy link
Contributor Author

@enxebre @JoelSpeed @alexander-demichev I'd like to merge those today. Please approve and LGTM

elmiko
elmiko approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020
@JoelSpeed
Copy link
Contributor

/approve
/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit d32f32d into openshift:master Jul 9, 2020
RadekManak pushed a commit to RadekManak/cluster-api-provider-gcp that referenced this pull request Apr 12, 2023
@k8s-ci-robot
Merge pull request openshift#94 from alexander-demicev/chart-docs
3cd83cb 
📖 Add helm chart to getting started doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko approved these changes

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@elmiko elmiko

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Danil-Grigorev @JoelSpeed @enxebre @openshift-ci-robot @elmiko @openshift-merge-robot