Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-25507: update golang.org/x/crypto module #78

Merged
merged 1 commit into from Feb 19, 2024
Merged

OCPBUGS-25507: update golang.org/x/crypto module #78

merged 1 commit into from Feb 19, 2024

Conversation

mkumatag
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 16, 2024
@openshift-ci-robot
Copy link

@mkumatag: This pull request references Jira Issue OCPBUGS-25507, which is invalid:

  • expected Jira Issue OCPBUGS-25507 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 16, 2024
@mkumatag
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@mkumatag: This pull request references Jira Issue OCPBUGS-25507, which is invalid:

  • expected dependent Jira Issue OCPBUGS-29590 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 16, 2024

@mkumatag: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mkumatag
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 16, 2024
@openshift-ci-robot
Copy link

@mkumatag: This pull request references Jira Issue OCPBUGS-25507, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29590 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-29590 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mkumatag
Copy link
Member Author

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2024
@mkumatag
Copy link
Member Author

@JoelSpeed can you please add backport-risk-assessed label?

@mkumatag
Copy link
Member Author

/cc @Prajyot-Parab @dharaneeshvrd

Prajyot-Parab
Prajyot-Parab approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2024
@JoelSpeed
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 16, 2024
@mkumatag
Copy link
Member Author

need cherry-pick-approved, staff-eng-approved labels as well. Any help is appreciated @Prashanth684

@sunzhaohua2
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 18, 2024
@mkumatag
Copy link
Member Author

need staff-eng-approved label as well.

@Prashanth684 Prashanth684 added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Feb 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 34fb625 into openshift:release-4.15 Feb 19, 2024
5 checks passed
@openshift-ci-robot
Copy link

@mkumatag: Jira Issue OCPBUGS-25507: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25507 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mkumatag mkumatag deleted the 415-update-crypto branch February 19, 2024 15:29
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ibmcloud-cluster-api-controllers-container-v4.15.0-202402191538.p0.g34fb625.assembly.stream.el9 for distgit ose-ibmcloud-cluster-api-controllers.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-02-19-162915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@Karthik-K-N Karthik-K-N Awaiting requested review from Karthik-K-N

@racheljpg racheljpg Awaiting requested review from racheljpg

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

@dharaneeshvrd dharaneeshvrd Awaiting requested review from dharaneeshvrd

Assignees

@jhou1 jhou1

@sunzhaohua2 sunzhaohua2

@Prajyot-Parab Prajyot-Parab

@miyadav miyadav

@huali9 huali9

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet