Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actuator events #103

Merged
merged 7 commits into from
Jan 3, 2019
Merged

Actuator events #103

merged 7 commits into from
Jan 3, 2019

Conversation

ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Dec 21, 2018 •
edited

Report machine events during Create and Delete operations.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 21, 2018
@ingvagabund ingvagabund removed the request for review from spangenberg December 21, 2018 13:16
@ingvagabund ingvagabund added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ingvagabund
Copy link
Member Author

/test e2e

@ingvagabund
Copy link
Member Author

/retest

1 similar comment
@ingvagabund
Copy link
Member Author

/retest

@ingvagabund
Go generate mock client
c30cbe5 
$ cd pkg/cloud/libvirt/client
$ go generate

To install mockgen:
$ go get github.com/golang/mock/gomock
$ go install github.com/golang/mock/mockgen
@ingvagabund
Move fake cluster clientset under test package
2357400 
Later, remove the fake cluster client in favor of runtime controller client.
@ingvagabund
Report machine events
1a22039
@ingvagabund
Unit test machine events
f370c34
@ingvagabund
Sync deps
f1e305e
@ingvagabund
Apply downstream patches
14247a5
@ingvagabund
Adapt actuator operations to new signatures
3ba02bf
@ingvagabund
Copy link
Member Author

/retest

2 similar comments
@ingvagabund
Copy link
Member Author

/retest

@ingvagabund
Copy link
Member Author

/retest

@ingvagabund ingvagabund mentioned this pull request Dec 23, 2018
Merged
@ingvagabund
Copy link
Member Author

/retest

4 similar comments
@ingvagabund
Copy link
Member Author

/retest

@ingvagabund
Copy link
Member Author

/retest

@ingvagabund
Copy link
Member Author

/retest

@ingvagabund
Copy link
Member Author

/retest

@paulfantom
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2019
@ingvagabund
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit c81a888 into openshift:master Jan 3, 2019
@ingvagabund ingvagabund deleted the actuator-events branch January 3, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfantom paulfantom Awaiting requested review from paulfantom

Assignees

@paulfantom paulfantom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ingvagabund @openshift-ci-robot @paulfantom @openshift-merge-robot