Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove providerconfig #107

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Remove providerconfig #107

merged 2 commits into from
Jan 11, 2019

Conversation

ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Jan 11, 2019

  • remove any use of the .providerConfig and ProviderConfig
  • rename testing resources to reflect new provider spec name
  • rename [Encode|Decode]ProviderConfig to [Encode|Decode]ProviderSpec

To be merged not before openshift/machine-api-operator#173

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 11, 2019
@ingvagabund
Copy link
Member Author

/retest

@ingvagabund
Copy link
Member Author

/test images

@enxebre
Copy link
Member

enxebre commented Jan 11, 2019

can you include a separate commit to remove the deprecated field from the vendored cluste-api i.e machine_types.go

@paulfantom
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2019
@ingvagabund
Copy link
Member Author

/retest

@enxebre
Copy link
Member

enxebre commented Jan 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit 0b7464a into openshift:master Jan 11, 2019
@ingvagabund ingvagabund deleted the remove-providerconfig branch January 11, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants