Validate machineset before reconciling #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
|
Same as openshift/cluster-api-provider-aws#140 :) /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Even thought the MachineSet type implements Validate() function, it's not called by default. The validation function is responsible for making sure every machine set matchLabels selector is matched with machine template labels. Given the validation is not performed by default, it is possible to create an invalid machineset that causes the machineset controller to start creating machine object one by one without any upper bound. Causing the machine controller to launch as many instances as there is machine objects.
|
Just updating the Makefile so the patch is actually applied when updating the deps. |
|
/lgtm At some point, it may be easier to fork the cluster-api repo and update the dependencies to track a branch there. Then we can rebase and cherry-pick into that branch as necessary rather than copy the patches around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even thought the MachineSet type implements Validate() function,
it's not called by default. The validation function is responsible
for making sure every machine set matchLabels selector is matched with
machine template labels. Given the validation is not performed by default,
it is possible to create an invalid machineset that causes the machineset
controller to start creating machine object one by one without any upper
bound. Causing the machine controller to launch as many instances as
there is machine objects.
Carried as downstream patch before kubernetes-sigs/cluster-api#669 gets resolved.