Cache leases IP's and do not use them on the machine creation #157
Conversation
cynepco3hahue
force-pushed
the
fix_cidr_issue
branch
from
3410f52
to
db4bca1
Compare
openshift-ci-robot
added
the
size/L
|
/test e2e-libvirt |
2 similar comments
|
/test e2e-libvirt |
|
/test e2e-libvirt |
|
/test e2e-libvirt |
|
No clue what's with the docker image not containing the needed files. Let's try again before we investigate: /test e2e-libvirt |
pkg/cloud/libvirt/client/network.go
Outdated
| ) | ||
|
|
||
| // Leases contains list of Lease |
There was a problem hiding this comment.
Not the most useful comment. :) Contains list of DHCP leases would be better IMO.
|
other than that lgtm. |
Workers got IP's from DHCP, by default first machine will get IP x.x.x.51, the second x.x.x.52... But if machine-controllers deployment restarted, it will start again from x.x.x.51 for new machines. To avoid it, we will cache IP leases on the first `Create()` call, and will generate new IP until we get IP that does not exist under the cache.
cynepco3hahue
force-pushed
the
fix_cidr_issue
branch
from
db4bca1
to
0dddf86
Compare
|
@cynepco3hahue: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zeenix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Workers got IP's from DHCP, by default first machine will get IP x.x.x.51,
the second x.x.x.52... But if machine-controllers deployment restarted, it
will start again from x.x.x.51 for new machines. To avoid it, we will cache
IP leases on the first
Create()call and will generate new IP until we getIP that does not exist under the cache.
Fixes #134