Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1887373: Add leader election mechanism to release-4.5 #211

Merged
merged 1 commit into from Oct 23, 2020
Merged

Bug 1887373: Add leader election mechanism to release-4.5 #211

merged 1 commit into from Oct 23, 2020

Conversation

andymcc
Copy link
Member

@andymcc andymcc commented Oct 12, 2020

This cherry-picks the fix from master/4.6 and integrates with:
openshift/machine-api-operator#664

Adding 3 new cli arguments for configuring leader elections:
-leader-elect
-leader-elect-lease-duration int
-leader-elect-resource-namespace string

Using leader election will add stronger guarantees than we have today
that only one controller is running at a time to protect against edge
cases where the deployment replica could be increased or upgrades with
permissive maxSurge.

(cherry picked from commit 5ccc992)

@openshift-ci-robot
Copy link
Contributor

@andymcc: This pull request references Bugzilla bug 1864352, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1864352: Add leader election mechanism to release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 12, 2020
@andymcc
Bug 1887373: Add leader election mechanism to release-4.5
3048e02 
This cherry-picks the fix from master/4.6 and integrates with:
openshift/machine-api-operator#664

Adding 3 new cli arguments for configuring leader elections:
-leader-elect
-leader-elect-lease-duration int
-leader-elect-resource-namespace string

Using leader election will add stronger guarantees than we have today
that only one controller is running at a time to protect against edge
cases where the deployment replica could be increased or upgrades with
permissive maxSurge.

(cherry picked from commit 5ccc992)
@andymcc andymcc changed the title Bug 1864352: Add leader election mechanism to release-4.5 Bug 1887373: Add leader election mechanism to release-4.5 Oct 12, 2020
@openshift-ci-robot openshift-ci-robot removed the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 12, 2020
@openshift-ci-robot
Copy link
Contributor

@andymcc: This pull request references Bugzilla bug 1887373, which is invalid:

  • expected the bug to target the "4.5.z" release, but it targets "---" instead
  • expected Bugzilla bug 1887373 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1887373: Add leader election mechanism to release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Oct 12, 2020
@andymcc
Copy link
Member Author

andymcc commented Oct 12, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@andymcc: This pull request references Bugzilla bug 1887373, which is invalid:

  • expected the bug to target the "4.5.z" release, but it targets "---" instead
  • expected Bugzilla bug 1887373 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@andymcc: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/actuator-pkg-staleness 3048e02 link /test actuator-pkg-staleness

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andymcc
Copy link
Member Author

andymcc commented Oct 12, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@andymcc: This pull request references Bugzilla bug 1887373, which is invalid:

  • expected Bugzilla bug 1887373 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andymcc
Copy link
Member Author

andymcc commented Oct 12, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@andymcc: This pull request references Bugzilla bug 1887373, which is invalid:

  • expected the bug to target the "4.5.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andymcc
Copy link
Member Author

andymcc commented Oct 12, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 12, 2020
@openshift-ci-robot
Copy link
Contributor

@andymcc: This pull request references Bugzilla bug 1887373, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1861896 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1861896 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 12, 2020
@cfergeau
Copy link
Contributor

/lgtm

@praveenkumar
Copy link
Contributor

/test e2e-libvirt

@Prashanth684 Prashanth684 mentioned this pull request Oct 14, 2020
Merged
@jaypoulz
Copy link

/retest

@praveenkumar
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2020
@Prashanth684
Copy link
Contributor

/test e2e-libvirt

@Prashanth684
Copy link
Contributor

e2e-libvirt passed. @praveenkumar @cfergeau can one of you add an approval ?

@cfergeau
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 23, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

@andymcc: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/actuator-pkg-staleness 3048e02 link /test actuator-pkg-staleness

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 499c445 into openshift:release-4.5 Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

@andymcc: All pull requests linked via external trackers have merged:

Bugzilla bug 1887373 has been moved to the MODIFIED state.

In response to this:

Bug 1887373: Add leader election mechanism to release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfergeau cfergeau cfergeau approved these changes

Assignees

@praveenkumar praveenkumar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@andymcc @openshift-ci-robot @cfergeau @praveenkumar @jaypoulz @Prashanth684 @openshift-bot @openshift-merge-robot @bparees