actuator: cleanup cloudinit and ignition volume on error, bump golang #223
Conversation
rphillips
force-pushed
the
fixes/cleanup_volume_creation
branch
2 times, most recently
from
da98983
to
54ecd7f
Compare
rphillips
changed the title
rphillips
force-pushed
the
fixes/cleanup_volume_creation
branch
from
23135ff
to
cd76670
Compare
|
/test e2e-libvirt |
|
/retest |
rphillips
force-pushed
the
fixes/cleanup_volume_creation
branch
from
cd76670
to
f8efac2
Compare
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| RUN yum install -y libvirt-devel | ||
|
|
||
| WORKDIR /go/src/github.com/openshift/cluster-api-provider-libvirt | ||
| COPY . . | ||
| RUN go build -o machine-controller-manager ./cmd/manager | ||
|
|
||
| FROM registry.svc.ci.openshift.org/ocp/4.6:base | ||
| FROM registry.ci.openshift.org/ocp/4.9:base | ||
| RUN INSTALL_PKGS=" \ |
There was a problem hiding this comment.
These changes are the same as 4156429
(not an objection, just linking the 2 PRs)
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-libvirt-machine-controllers-container-v4.9.0-202311250023.p0.g59ae2ed.assembly.stream for distgit ose-libvirt-machine-controllers. |
I kept getting
storage volume 'test1-kbpwl-worker-0-shxhm.ignition' exists alreadyerrors on recent installs.This PR cleans up the cloud-init and ignition volumes on error. Additionally, it bumps golang to 1.16.