OCPBUGS-18338: Fix CI by running tests natively by default #261
Conversation
Tests like lint and vet used to be ran within a container engine by default if an engine was detected, both locally and in CI. Up until now no container engine was detected in CI, so tests would run natively there. Now that the base image we use in CI has now started shipping `podman`, a container engine is detected by default and tests are run within podman by default. But creating nested containers doesn't work in CI at the moment and thus results in a test failure. As such we are switching the default behaviour for tests (both locally and in CI), where now by default no container engine is used to run tests, even if one is detected, but instead tests are run natively unless otherwise specified.
openshift-ci-robot
added
jira/valid-reference
|
@damdo: This pull request references Jira Issue OCPBUGS-18338, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm /assign @cfergeau |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/test e2e-libvirt |
|
/jira refresh |
|
@damdo: This pull request references Jira Issue OCPBUGS-18338, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
cc. @praveenkumar |
|
@damdo: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
failure of /approve |
|
/approved |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@damdo: Jira Issue OCPBUGS-18338 is in an unrecognized state (Closed) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Tests like lint and vet used to be ran within a container engine by default if an engine was detected, both locally and in CI.
Up until now no container engine was detected in CI, so tests would run natively there.
Now that the base image we use in CI has now started shipping
podman, a container engine is detected by default and tests are run within podman by default. But creating nested containers doesn't work in CI at the moment and thus results in a test failure.As such we are switching the default behaviour for tests (both locally and in CI), where now by
default no container engine is used to run tests, even if one is detected, but instead tests are run natively unless otherwise specified.