Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1820421: validate that flavor exists for machine #112

Merged
merged 1 commit into from Aug 21, 2020

Conversation

Fedosin
Copy link

@Fedosin Fedosin commented Aug 20, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Aug 20, 2020
@openshift-ci-robot
Copy link

@Fedosin: This pull request references Bugzilla bug 1820421, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1820421: validate that flavor exists for machine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 20, 2020
@Fedosin
Copy link
Author

Fedosin commented Aug 21, 2020

/test e2e-openstack

1 similar comment
@pierreprinetti
Copy link
Member

/test e2e-openstack

@iamemilio
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, iamemilio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6eeeddf into openshift:master Aug 21, 2020
@openshift-ci-robot
Copy link

@Fedosin: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-openstack#112. Bugzilla bug 1820421 has been moved to the MODIFIED state.

In response to this:

Bug 1820421: validate that flavor exists for machine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
* Updated cluster-api for renaming ProviderConfig

... to ProviderSpec openshift#109

* Changed providerConfig to providerSpec

also added two little railguards in the actuator, to not panic if there
is no `providerSpec.Value`. In theory with this, it is possible to
update the controller and edit existing manifests from `providerConfig`
to `providerSpec`.

* Fixed Gopkg.lock

This resulted in removing a couple of corba license files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants