Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1909723: Updating ose-openstack-machine-controllers builder & base images to be consistent with ART #132

Merged
merged 1 commit into from Dec 21, 2020
Merged

Bug 1909723: Updating ose-openstack-machine-controllers builder & base images to be consistent with ART #132

merged 1 commit into from Dec 21, 2020

Conversation

jupierce
Copy link

@jupierce jupierce commented Oct 7, 2020 •
edited

Updating ose-openstack-machine-controllers builder & base images to be consistent with ART
Reconciling with https://github.com/openshift/ocp-build-data/tree/f66c03011773dc3755ad874fc691be612914d65f/images/ose-openstack-machine-controllers.yml

If you have any questions about this pull request, please reach out to @art-team in the #aos-art coreos slack channel.

Depends on openshift/images#44 . Allow it to merge and then run /test all on this PR.

@jupierce jupierce force-pushed the art-consistency-openshift-4.7-ose-openstack-machine-controllers branch from e4bd246 to ad9f4fb Compare October 7, 2020 15:54
@pierreprinetti
Copy link
Member

/retest

@pierreprinetti
Copy link
Member

/test all

@pierreprinetti pierreprinetti mentioned this pull request Dec 21, 2020
Closed
@pierreprinetti
Copy link
Member

/approve
/lgtm
/hold for CI

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 21, 2020
@pierreprinetti pierreprinetti changed the title Updating ose-openstack-machine-controllers builder & base images to be consistent with ART Bug 1909723: Updating ose-openstack-machine-controllers builder & base images to be consistent with ART Dec 21, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 21, 2020
@openshift-ci-robot
Copy link

@jupierce: This pull request references Bugzilla bug 1909723, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1909723: Updating ose-openstack-machine-controllers builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2020
@pierreprinetti
Copy link
Member

Hey bot, maybe you like puppies. Can you merge this please?

/woof

@openshift-ci-robot
Copy link

@pierreprinetti: dog image

In response to this:

Hey bot, maybe you like puppies. Can you merge this please?

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ee98fb1 into openshift:master Dec 21, 2020
@openshift-ci-robot
Copy link

@jupierce: All pull requests linked via external trackers have merged:

Bugzilla bug 1909723 has been moved to the MODIFIED state.

In response to this:

Bug 1909723: Updating ose-openstack-machine-controllers builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@YorikSar @pierreprinetti
Turn on automatic reauth for OpenStack client (openshift#160)
ceed385 
Currently after token expires, all further requests to OpenStack API
fail because of auth error. With this flag gophercloud will try to
recreate token on receiving 401 error from API.

Fixes: openshift#132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamemilio iamemilio Awaiting requested review from iamemilio

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

Assignees

@pierreprinetti pierreprinetti

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jupierce @pierreprinetti @openshift-ci-robot @openshift-merge-robot