Drop openssh from the image #135
Conversation
|
/lgtm |
|
@EmilienM: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This looks fine. I would also see some doc + a script to make it easier to build CAPO for dev/CI testing; I know you have some handy scripts / tips, maybe we can share them here. |
|
If we assume that |
|
@pierreprinetti to standardize the format whatever it means: #3 |
We don't need openssh in the image so there is no reason to keep it.
Fedosin
force-pushed
the
dockerfile.test
branch
from
95e4022
to
d4bcaea
Compare
|
AWS patch openshift/cluster-api-provider-aws#317 |
|
/lgtm Let's keep an eye on the CI periodics in the coming hours, to make sure everything keeps on working properly. /cc mandre |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
openssh is not expected to be useful in the production image. cf: openshift#135
openssh is not expected to be useful in the production image. cf: openshift#135
openssh is not expected to be useful in the production image. cf: openshift#135
This patch changes the following: * Use the syntax of mikefarah's yq. * Check if the installed yq is a python script and error out if it is.
* Re-apply of new yq usage Just re-applied the usage of yq from openshift#135, because they were overridden by openshift#141. * Fixed var names CLOUD to OS_CLOUD
We don't need openssh in the image so there is no reason to keep it.