Bug 1913736: do not fetch image id when booting from volume

[Fedosin]

When we boot a machine from volume, we don't need to fetch the image id.

[openshift-ci-robot]

@Fedosin: This pull request references Bugzilla bug 1913736, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1913736: do not validate image when booting from volume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mandre]

I'm still seeing this with the release image built for this patch. registry.build02.ci.openshift.org/ci-op-dpffn3p3/release:latest :

E0107 14:56:06.240279       1 actuator.go:574] Machine error mandre-rq88b-worker-0-wjkf4: error creating Openstack instance: Create new server err: Unable to find image with name 
W0107 14:56:06.240334       1 controller.go:317] mandre-rq88b-worker-0-wjkf4: failed to create machine: error creating Openstack instance: Create new server err: Unable to find image with name 
E0107 14:56:06.240504       1 controller.go:237] controller "msg"="Reconciler error" "error"="error creating Openstack instance: Create new server err: Unable to find image with name " "controller"="machine_controller" "name"="mandre-rq88b-worker-0-wjkf4" "namespace"="openshift-machine-api" 

[mandre]

There's another issue with https://github.com/openshift/cluster-api-provider-openstack/pull/126/files#diff-74426b0daa2349d4dffb9633a1a3ef807c0136fc398d0275213a4734c336f067

Previously, getImageID() would return an empty string when given an empty image name, while now imageutils.IDFromName() returns an error.

[openshift-ci-robot]

@Fedosin: This pull request references Bugzilla bug 1913736, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1913736: do not validate image when booting from volume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mandre]

This time it worked. Thanks.

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mandre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@Fedosin: All pull requests linked via external trackers have merged:

• openshift/cluster-api-provider-openstack#148

Bugzilla bug 1913736 has been moved to the MODIFIED state.

In response to this:

Bug 1913736: do not fetch image id when booting from volume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.