Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM 1686: Move webhook CA injection into webhook resource #264

Merged
merged 1 commit into from
Oct 13, 2023
Merged

UPSTREAM 1686: Move webhook CA injection into webhook resource #264

merged 1 commit into from
Oct 13, 2023

Conversation

mdbooth
Copy link

@mdbooth mdbooth commented Oct 4, 2023 •
edited

Upstream PR kubernetes-sigs#1686

Required for generation of cluster-capi-operator manifests.

@mdbooth
Copy link
Author

mdbooth commented Oct 4, 2023

/approve

@mdbooth
Copy link
Author

mdbooth commented Oct 4, 2023

/hold

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 4, 2023
@mandre
Copy link
Member

mandre commented Oct 4, 2023

/retitle UPSTREAM 1686: Move webhook CA injection into webhook resource

@openshift-ci openshift-ci bot changed the title CHERRYPICK: Move webhook CA injection into webhook resource UPSTREAM 1686: Move webhook CA injection into webhook resource Oct 4, 2023
@mdbooth
Copy link
Author

mdbooth commented Oct 13, 2023

/test all

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2023

@mdbooth: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mdbooth
Copy link
Author

mdbooth commented Oct 13, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
mandre
mandre reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 9a1e2cd into openshift:main Oct 13, 2023
3 checks passed
@mdbooth mdbooth deleted the webhook-kustomize branch October 18, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

@stephenfin stephenfin Awaiting requested review from stephenfin

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdbooth @mandre