Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARRY: Mark CAPO as second level operator #267

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

mdbooth
Copy link

@mdbooth mdbooth commented Oct 9, 2023

This is required for it to be included in the release payload. CAPO is actually deployed by cluster-capi-operator, but is not directly referenced by cluster-capi-operator. cluster-capi-operator instead consumes a ConfigMap deployed by CAPO. CAPO must be included in the release payload in order for cluster-capi-operator to be able to consume this ConfigMap.

/hold

This is required for it to be included in the release payload. CAPO is
actually deployed by cluster-capi-operator, but is not directly
referenced by cluster-capi-operator. cluster-capi-operator instead
consumes a ConfigMap deployed by CAPO. CAPO must be included in the
release payload in order for cluster-capi-operator to be able to consume
this ConfigMap.
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2023
@mdbooth
Copy link
Author

mdbooth commented Oct 10, 2023

/approve

@JoelSpeed
Copy link

This means that the manifests from this repo will be included into the openshift payload. While the manifests are not marked up for CVO to deploy them, the manifests are marked up for cluster capi operator to deploy them
Nothing is referencing this image right now so this should be a safe change
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

@JoelSpeed: changing LGTM is restricted to collaborators

In response to this:

This means that the manifests from this repo will be included into the openshift payload. While the manifests are not marked up for CVO to deploy them, the manifests are marked up for cluster capi operator to deploy them
Nothing is referencing this image right now so this should be a safe change
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@pierreprinetti
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@mdbooth
Copy link
Author

mdbooth commented Oct 10, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

@mdbooth: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 086bfdb into openshift:main Oct 10, 2023
3 checks passed
@mdbooth mdbooth deleted the capo-2lo branch October 10, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants