openshift: Add make verify and test

[mdbooth]

Also fix lint issues hightlighted by these tests.

[mdbooth]

@stephenfin Would you be able to make the e2e tests execute under make -C openshift test?

[openshift-ci]

@mdbooth: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mandre]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [mandre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mdbooth]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@mdbooth: new pull request created: #282

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build openstack-cluster-api-controllers-container-v4.15.0-202311282232.p0.ga6039e2.assembly.stream for distgit openstack-cluster-api-controllers.
All builds following this will include this PR.