Bug 1751471: Machine update: create before delete #82
Conversation
With this change, the new machine is created first. The desired outcome is that in case the new machine specification is not valid, its creation fails and the old one does not get deleted. Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1751471
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@pierreprinetti: This pull request references Bugzilla bug 1751471, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
approved
|
/hold Please remove the hold after e2e-openstack job returns successfully. |
openshift-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@pierreprinetti: All pull requests linked via external trackers have merged. Bugzilla bug 1751471 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bump our gophercloud/utils to include the fix linked below: gophercloud/utils@9427fef This commit also brings in gophercloud/utils as an actual vendored package rather than as a git module.
With this change, the new machine is created first. The desired outcome
is that in case the new machine specification is not valid, its
creation fails and the old one does not get deleted.
Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1751471
/cc Fedosin mandre