Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1815029: Allow to create network ports without allowed address pairs #86

Merged
merged 1 commit into from Mar 23, 2020
Merged

Bug 1815029: Allow to create network ports without allowed address pairs #86

merged 1 commit into from Mar 23, 2020

Conversation

Fedosin
Copy link

@Fedosin Fedosin commented Mar 19, 2020

This commit allows to set a flag to NetworkParameter that disables allowed address pairs creation for all network ports.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 19, 2020
@openshift-ci-robot
Copy link

@Fedosin: This pull request references Bugzilla bug 1815029, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1815029: Allow to create network ports without allowed address pairs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@pierreprinetti
Copy link
Member

/test e2e-openstack

@Fedosin
Copy link
Author

Fedosin commented Mar 19, 2020

/retest

1 similar comment
@Fedosin
Copy link
Author

Fedosin commented Mar 19, 2020

/retest

@Fedosin
Copy link
Author

Fedosin commented Mar 20, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2020
@Fedosin
Bug 1815029: Allow to create network ports without allowed address pairs
ba3b3c5 
This commit allows to set a flag to NetworkParameter that disables
allowed address pairs creation for all network ports.
@Fedosin
Copy link
Author

Fedosin commented Mar 20, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2020
@Fedosin Fedosin mentioned this pull request Mar 20, 2020
Merged
@tombarron
Copy link

Nice to see that manila-csi works with this when the NFS export location is (as with TripleO) on an isolated storage network!

@pierreprinetti
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Fedosin,pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3311de9 into openshift:master Mar 23, 2020
@openshift-ci-robot
Copy link

@Fedosin: All pull requests linked via external trackers have merged. Bugzilla bug 1815029 has been moved to the MODIFIED state.

In response to this:

Bug 1815029: Allow to create network ports without allowed address pairs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link
Author

Fedosin commented May 22, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@Fedosin: new pull request created: #95

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adduarte adduarte Awaiting requested review from adduarte

@tomassedovic tomassedovic Awaiting requested review from tomassedovic

Assignees

@pierreprinetti pierreprinetti

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Fedosin @openshift-ci-robot @pierreprinetti @tombarron @openshift-cherrypick-robot @openshift-merge-robot