Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-10119: Updating ose-ovirt-machine-controllers images to be consistent with ART #174

Conversation

openshift-bot
Copy link

@openshift-bot openshift-bot commented Mar 9, 2023

Updating ose-ovirt-machine-controllers images to be consistent with ART
TLDR:
Component owners, please ensure that this PR merges as it impacts the fidelity
of your CI signal. Patch-manager / leads, this PR is a no-op from a product
perspective -- feel free to manually apply any labels (e.g. jira/valid-bug) to help the
PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is
to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test
to remove this tag and help the PR to merge.

Detail:
This repository is out of sync with the downstream product builds for this component.
One or more images differ from those being used by ART to create product builds. This
should be addressed to ensure that the component's CI testing is accurately
reflecting what customers will experience.

The information within the following ART component metadata is driving this alignment
request: ose-ovirt-machine-controllers.yml.

The vast majority of these PRs are opened because a different Golang version is being
used to build the downstream component. ART compiles most components with the version
of Golang being used by the control plane for a given OpenShift release. Exceptions
to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift
architecture team and communicated to the ART team.

Roles & Responsibilities:

  • Component owners are responsible for ensuring these alignment PRs merge with passing
    tests OR that necessary metadata changes are reported to the ART team: @release-artists
    in #forum-ocp-art on Slack. If necessary, the changes required by this pull request can be
    introduced with a separate PR opened by the component team. Once the repository is aligned,
    this PR will be closed automatically.
  • Patch-manager or those with sufficient privileges within this repository may add
    any required labels to ensure the PR merges once tests are passing. Downstream builds
    are already being built with these changes. Merging this PR only improves the fidelity
    of our CI.

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
  from_repository: true

If you have any questions about this pull request, please reach out to @release-artists in the #forum-ocp-art coreos slack channel.

@openshift-bot openshift-bot force-pushed the art-consistency-openshift-4.14-ose-ovirt-machine-controllers branch from cb117fe to 4cddb88 Compare March 9, 2023 11:06
@openshift-bot openshift-bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 9, 2023
@openshift-ci openshift-ci bot requested review from engelmi and eslutsky March 9, 2023 11:06
@openshift-bot openshift-bot force-pushed the art-consistency-openshift-4.14-ose-ovirt-machine-controllers branch 2 times, most recently from 5be1294 to 8cbeec9 Compare April 20, 2023 05:22
@openshift-bot openshift-bot force-pushed the art-consistency-openshift-4.14-ose-ovirt-machine-controllers branch from 8cbeec9 to 156895e Compare April 22, 2023 15:18
@JoelSpeed
Copy link

/approve
/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2023
@JoelSpeed
Copy link

/override ci/prow/e2e-ovirt

Can no longer install on ovirt so this E2E is broken

@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2023

@JoelSpeed: JoelSpeed unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

In response to this:

/override ci/prow/e2e-ovirt

Can no longer install on ovirt so this E2E is broken

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot openshift-bot changed the title Updating ose-ovirt-machine-controllers images to be consistent with ART 15143237: Updating ose-ovirt-machine-controllers images to be consistent with ART Jul 27, 2023
@engelmi
Copy link

engelmi commented Jul 28, 2023

/override ci/prow/e2e-ovirt

Can no longer install on ovirt so this E2E is broken

@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2023

@engelmi: Overrode contexts on behalf of engelmi: ci/prow/e2e-ovirt

In response to this:

/override ci/prow/e2e-ovirt

Can no longer install on ovirt so this E2E is broken

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2023

@openshift-bot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engelmi, JoelSpeed, openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5d70863 into openshift:master Jul 28, 2023
5 checks passed
@JoelSpeed
Copy link

/retitle OCPBUGS-10119: Updating ose-ovirt-machine-controllers images to be consistent with ART

@openshift-ci openshift-ci bot changed the title 15143237: Updating ose-ovirt-machine-controllers images to be consistent with ART OCPBUGS-10119: Updating ose-ovirt-machine-controllers images to be consistent with ART Jul 28, 2023
@openshift-ci-robot
Copy link

@openshift-bot: Jira Issue OCPBUGS-10119: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10119 has been moved to the MODIFIED state.

In response to this:

Updating ose-ovirt-machine-controllers images to be consistent with ART
TLDR:
Component owners, please ensure that this PR merges as it impacts the fidelity
of your CI signal. Patch-manager / leads, this PR is a no-op from a product
perspective -- feel free to manually apply any labels (e.g. jira/valid-bug) to help the
PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is
to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test
to remove this tag and help the PR to merge.

Detail:
This repository is out of sync with the downstream product builds for this component.
One or more images differ from those being used by ART to create product builds. This
should be addressed to ensure that the component's CI testing is accurately
reflecting what customers will experience.

The information within the following ART component metadata is driving this alignment
request: ose-ovirt-machine-controllers.yml.

The vast majority of these PRs are opened because a different Golang version is being
used to build the downstream component. ART compiles most components with the version
of Golang being used by the control plane for a given OpenShift release. Exceptions
to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift
architecture team and communicated to the ART team.

Roles & Responsibilities:

  • Component owners are responsible for ensuring these alignment PRs merge with passing
    tests OR that necessary metadata changes are reported to the ART team: @release-artists
    in #forum-ocp-art on Slack. If necessary, the changes required by this pull request can be
    introduced with a separate PR opened by the component team. Once the repository is aligned,
    this PR will be closed automatically.
  • Patch-manager or those with sufficient privileges within this repository may add
    any required labels to ensure the PR merges once tests are passing. Downstream builds
    are already being built with these changes. Merging this PR only improves the fidelity
    of our CI.

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
 from_repository: true

If you have any questions about this pull request, please reach out to @release-artists in the #forum-ocp-art coreos slack channel.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Author

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovirt-machine-controllers-container-v4.15.0-202311202349.p0.g5d70863.assembly.stream for distgit ose-ovirt-machine-controllers.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants