New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1813741: [ovirt] allow template parameters customization (mem/cpu/disk) in the machine #41
Bug 1813741: [ovirt] allow template parameters customization (mem/cpu/disk) in the machine #41
Conversation
@rgolangh: This pull request references Bugzilla bug 1813741, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
@@ -49,7 +49,23 @@ type OvirtMachineProviderSpec struct { | |||
// the oVirt cluster this VM instance belongs too | |||
ClusterId string `json:"cluster_id"` | |||
|
|||
// Sockets is the number of sockets for a VM. | |||
// Total CPUs is Sockets * Cores * Threads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe surround with brackets (Sockets * Cores * Threads) to make it clearer it's a calculation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack
// Total CPUs is Sockets * Cores * Threads | ||
Cores int32 `json:"cores"` | ||
|
||
// Thread is the number of thread per core. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
threads maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack
Signed-off-by: Roy Golan <rgolan@redhat.com>
613a225
to
764f14f
Compare
return fmt.Errorf("the VM %s(%s) doesn't have a bootable disk - was Blank template used by mistake?", | ||
createdVM.MustVm().MustName(), createdVM.MustVm().MustId()) | ||
} | ||
// extend the disk if requested size is bigger then template. We won't support shrinking it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
than
764f14f
to
980330e
Compare
VM instance creation now supports: - instance_type - memory (if instance type is not defined) - cpu (if instance type is not defined) - vm type - os disk extension Signed-off-by: Roy Golan <rgolan@redhat.com>
980330e
to
c371c7e
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bennyz, rgolangh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cancel hold |
/test images |
/unhold |
@rgolangh: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-ovirt#41. Bugzilla bug 1813741 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update the provider spec with mem/cpu/disk properties