Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1830852: Generate bindata for network interfaces #46

Merged
merged 1 commit into from May 4, 2020

Conversation

rgolangh
Copy link

@rgolangh rgolangh commented May 4, 2020

Need to run make generate

Need to run `make generate`

Signed-off-by: Roy Golan <rgolan@redhat.com>
@openshift-ci-robot
Copy link

@rgolangh: An error was encountered searching for bug 1830852 on the Bugzilla server at https://bugzilla.redhat.com:

Get https://bugzilla.redhat.com/rest/bug/1830852?api_key=CENSORED: dial tcp: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1830852: Generate bindata for network interfaces

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rgolangh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2020
@rgolangh
Copy link
Author

rgolangh commented May 4, 2020

/bugzilla-refresh

@rgolangh rgolangh merged commit 599ffdd into openshift:master May 4, 2020
@openshift-ci-robot
Copy link

@rgolangh: Bugzilla bug 1830852 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Bug 1830852: Generate bindata for network interfaces

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bennyz
Copy link
Member

bennyz commented May 4, 2020

/lgtm

@openshift-merge-robot
Copy link

This PR was merged in the time period when ci-operator was mistakenly reporting failed tests as passing.

If this repository has ci-operator jobs, please inspect their test results even if passing, and consider the need for fixing or even reverting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants